Fixing check Y_CHECK_PREFER_LINES_EXISTS #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
| Please bring your branch up-to-date with the base branch before we try to merge this to avoid potential merge conflicts. |
bjoern-jueliger-sap approved these changes Jul 29, 2022
| small comment: as noted in https://github.com/SAP/code-pal-for-abap/runs/7577593608, this code introduces the use of Data Element ABAP_BOOLEAN, whereas the rest of the codebase only uses ABAP_BOOL which is built-in via the ABAP Type Group |
D074020 added a commit to D074020/code-pal-for-abap that referenced this pull request Jul 29, 2022
Fixing check Y_CHECK_PREFER_LINES_EXISTS (SAP#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #547
Fixing the check Y_CHECK_PREFER_LINES_EXISTS.
The check has reported iterations which include necessary statements. Due to that the statements within the iterations are necessary, the reporting of them as findings is incorrect. This should be solved now.