Skip to content

Conversation

@KavithaSiva
Copy link
Contributor

@KavithaSiva KavithaSiva commented Dec 4, 2025

Context

Updates orval config to ignore linting issues with JSON examples in spec.

With recent updates to prompt registry spec: https://github.tools.sap/AI/prompt-registry/pull/310 the SDK generation step was failing.

Reason is we use orval in the post generation step to generate zod schemas, and one of the descriptions in the spec file:

This selector allows you to define the scope of translation, such as specific placeholders or messages with specific roles. For example, `{"category": "placeholders", "items": ["user_input"], "source_language": "de-DE"}` targets the value of "user_input" in `placeholder_values` specified in the request payload; and considers the value to be in German. 

uses double quotes in the JSON example which is escaped using \ by orval leading to linting errors.
As this lint rule severity is low, I decided to ignore the rule instead.

@KavithaSiva KavithaSiva marked this pull request as ready for review December 4, 2025 17:03
@KavithaSiva KavithaSiva changed the title Fix: Update orval configuration for handling JSON examples in specification Fix: Update orval configuration for handling JSON examples in prompt registry specification Dec 4, 2025
@KavithaSiva KavithaSiva changed the title Fix: Update orval configuration for handling JSON examples in prompt registry specification fix: Update orval configuration for handling JSON examples in prompt registry specification Dec 4, 2025
Copy link
Member

@davidkna-sap davidkna-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1293 I added it to the eslint config, but this should be fine too and a bit more targeted.

@KavithaSiva KavithaSiva merged commit ddea857 into main Dec 5, 2025
13 checks passed
@KavithaSiva KavithaSiva deleted the fix/orval-eslint-config branch December 5, 2025 09:00
@ZhongpinWang
Copy link
Contributor

I would even want to disable eslint for src/zod folder. The zod file is generated and makes almost no sense to lint / prettify it.
If you want @davidkna-sap , you can do this in your #1293. Check the package json in prompt registry package and modify both lint and lint:fix (perhaps also add this folder to a local prettierignore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants