This repository was archived by the owner on Nov 13, 2021. It is now read-only.
added more precise comments based on CodeJam in Bratislava #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
IObert reviewed Jul 16, 2019
qmacro suggested changes Aug 27, 2019
There was a problem hiding this comment.
Nice additions, only some very minor changes please. Thanks! Can you also re-take the second command palette screenshot so it's in context - it currently shows you working in the tutorial content. Alternatively, you could omit that screenshot and any reference to it.
exercises/01/readme.md Outdated
| | ||
| To be able to open VS Code from the usual OS command line you need to add the installation path of VS Code to the environment variable PATH. There's an option to do this via the `Command Palette` in VS code. | ||
| | ||
| Open the `Command Palette` by pressing `Ctrl+Shift+P` in VS Code or via the menu bar. |
There was a problem hiding this comment.
- how about on macOS?
- is "P" really upper case in "Ctrl-Shift-P"? I think the convention is to show the keys, i.e. Ctrl-Shift-p
- via the menu bar -> via menu path View -> Command Palette
exercises/01/readme.md Outdated
| | ||
| Open the `Command Palette` by pressing `Ctrl+Shift+P` in VS Code or via the menu bar. | ||
| | ||
|  |
There was a problem hiding this comment.
- please use better description in the [ ... ] part
- also capitalise Command Palette here (and elsewhere)
exercises/01/readme.md Outdated
| | ||
| Search for `code` the command palette and execute `Install 'code' command in PATH`. | ||
| | ||
|  |
There was a problem hiding this comment.
- same comment as earlier - better desc and capitalisation please
exercises/01/readme.md Outdated
| | ||
| A success message for the process should then appear at the bottom right of the screen. | ||
| | ||
|  |
There was a problem hiding this comment.
- same comment as earlier - better desc and capitalisation please
exercises/02/readme.md Outdated
| | ||
| ### 1. Initialize a new CAP project | ||
| | ||
| Before you start creating a new project it's highly recommended to create a dedicated directory for this CodeJam within your users directory instead of any system directories (e.g. DO NOT work in C:\Windows\System32). |
There was a problem hiding this comment.
- it's highly recommended to -> we recommend that you
- good tip, btw!
exercises/04/readme.md Outdated
| | ||
| :point_right: Create a `csv/` directory within the `db/` directory, and copy into it the CSV files (from this repository) [my.bookshop-Books.csv](my.bookshop-Books.csv) and [my.bookshop-Authors.csv](my.bookshop-Authors.csv). Use the "Raw" link from within each of these GitHub resources to get the actual CSV data to download (and don't forget to ensure the `.csv` extension is used for the files that you save). | ||
| | ||
|  |
There was a problem hiding this comment.
- please capitalise appropriately even in descriptions of images (csv -> CSV) - these show up on screen readers which will know to pronounce the acronym CSV only if it's written in capitals
exercises/10/readme.md Outdated
| | ||
| ### 1. Sign in to Cloud Foundry | ||
| | ||
| :point_right: Run the following command from your command line to log in to the referenced Cloud Foundry endpoint. When prompted use your SAP Cloud Platform credentials |
There was a problem hiding this comment.
- please don't forget period at end of sentence
qmacro approved these changes Aug 28, 2019
| Thanks @maxstreifeneder |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.