Skip to content

Add Support to RxSwift 6.1 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2021
Merged

Add Support to RxSwift 6.1 #86

merged 4 commits into from
Mar 5, 2021

Conversation

@Guerrix
Copy link
Contributor

@Guerrix Guerrix commented Mar 3, 2021

Motivation and Context

When doing a pod update to update to RxSwift 6.10 (Ethan1) the NSObject+Rx reverts to 2.1.0 from 5.2.0 making NSObject+Rx break the build.

Description

  • Update podspect
  • Update CircleCI config
  • Regenerate dependencies: pod update and carthage update
ashfurrow
ashfurrow approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This looks good to me. I'll get this merged now and try to release it soon 🙏
@ashfurrow ashfurrow merged commit 855618d into RxSwiftCommunity:master Mar 5, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @Guerrix! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@Guerrix Guerrix deleted the feature/FixRxSwift6Support branch March 5, 2021 20:14
@ashfurrow
Copy link
Member

ashfurrow commented Mar 5, 2021 •
edited
Loading

Hmm, looks like CI is failing now: https://app.circleci.com/pipelines/github/RxSwiftCommunity/NSObject-Rx/6/workflows/7d796cbb-a8a7-4518-86fc-563794e9631e/jobs/97/steps I'm not a Carthage user – any ideas about what's up here?

(Edit: No pressure or anything here. CI failures happen, please don't feel bad or anything!)
@Guerrix
Copy link
Contributor Author

Guerrix commented Mar 5, 2021

@ashfurrow I'm not an avid Carthage user either, but I had similar issues when ran carthage update and solve them by running carthage update --platform iOS --use-xcframeworks instead.
@Guerrix Guerrix self-assigned this Mar 6, 2021
@Guerrix Guerrix restored the feature/FixRxSwift6Support branch March 6, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Guerrix @ashfurrow