Swift 5 support #67
Merged
Swift 5 support #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding RxSwift 5.0.x support
freak4pc requested changes May 2, 2019
ashfurrow reviewed May 2, 2019
* change version in Changelog and podspec * use new Xcode for building
| @fassko Thanks for you work here! I just realized this is one of the only projects where we didn't update to Circle v2 from v1 - so CI just doesn't run anymore. Is there any chance you could find the time to do that? It should be mostly straightforward |
| @freak4pc Sure I will create an issue and do it. I have done it for some of my projects. |
| I just discovered that there is an issue created by me :D |
| self-five to past @fassko |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding RxSwift 5.0.x support