block-padding: remove PadType and add pad_detached method #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
tarcieri approved these changes Sep 24, 2025
newpavlov changed the title PadTypePadType and add pad_detached method newpavlov added a commit that referenced this pull request Oct 6, 2025
### Added - `Padding::pad_detached` method ([#1225]) ### Changed - Migrated from `generic-array` to `hybrid-array` ([#944]) - Edition changed to 2024 and MSRV bumped to 1.85 ([#1149]) - Merged `RawPadding` and `Padding` traits ([#1217]) - Renamed `UnpadError` to `Error` ([#1225]) ### Removed - `Block` type alias ([#1217]) - `PadType` enum and associated type on the `Padding` trait ([#1225]) [#944]: #944 [#1149]: #1149 [#1217]: #1217 [#1225]: #1225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PadTypeis used only in the default implementation ofunpad_blocksand ininout. To handle the latter casePadding::pad_detachedis added.