Matrix4x3 v2 #433
Open
Matrix4x3 v2 #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Firestar99 force-pushed the vec3-12-bytes branch from db60a40 to ce5d860 Compare Firestar99 force-pushed the matrix4x3_v2 branch from e3acc34 to 404c094 Compare 
LegNeato requested changes Oct 16, 2025
| /// Primarily used in ray tracing extensions to represent object rotation, scale and translation. | ||
| /// | ||
| /// # Limitations | ||
| /// These Limitations apply to all structs marked with `#[spirv(matrix)]`, which `Matrix4x3` is the only one in |
There was a problem hiding this comment.
This feels a bit too inward facing. Just state the limitations. I guess you can optionally ask for a task.
| pub y: Vec3A, | ||
| pub z: Vec3A, | ||
| pub w: Vec3A, | ||
| pub x_axis: Vec3A, |
There was a problem hiding this comment.
Why did this change? Is it more or less consistent with other APIs?
There was a problem hiding this comment.
More consistent, now the member names are the same of glam's matrices. Split it out into a separate commit to make it easier to reason about
rust-gpu/crates/spirv-std/src/matrix.rs
Lines 29 to 38 in 951a990
Firestar99 force-pushed the matrix4x3_v2 branch from 404c094 to 786a458 Compare 
Firestar99 force-pushed the matrix4x3_v2 branch from 786a458 to 951a990 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Requires #380