Refactoring #14
Merged
Refactoring #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
GabrielBarberini commented Dec 28, 2023
GabrielBarberini commented - Improve code style and readability
- Group API routes by tag as different modules
- Fix pylint errors
refactors repositories standardizes controller exception handling refactors application routes fixes repositories connection close timing updates postman collection updates README fixes pylint errors fixes pylint errors apply black style to modules Update pylint.yml Update pylint.yml Update pylint.yml disable warnings
GabrielBarberini force-pushed the refactoring branch from 671aa6a to 83b0e4e Compare 
Collaborator Author
| JFYI: All integration tests passed for this. |
Member
Gui-FernandesBR left a comment
Gui-FernandesBR left a comment There was a problem hiding this comment.
Overall it's a very good work!
When reviewing 29 files, I may not be able to catch all the details, but I tried my best, hope you can find it helpful.
Collaborator Author
| I will have to remove W0511 from pylint as well since we will persist using #TODO for now |
removes W0511 (tolerates #TODO)
Gui-FernandesBR approved these changes Jan 21, 2024
Member
Gui-FernandesBR left a comment
Gui-FernandesBR left a comment There was a problem hiding this comment.
Good job @GabrielBarberini !!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.