- Notifications
You must be signed in to change notification settings - Fork 7
AB#74319 : Save records as draft #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
estelafs left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything working as expected, i just did some small improvements:
Added missing JSDocs and translations, removed console logs and unused imports, added data checks and added the empty template when table don't have drafts to display
Also, @AntoineRelief , the draft feature should be available in the here in the shared-form-modal when adding or updating a record from a grid?
… enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
libs/shared/src/lib/components/draft-record-modal/draft-record-modal.component.ts Outdated Show resolved Hide resolved
libs/shared/src/lib/components/select-draft-record-modal/graphql/queries.ts Outdated Show resolved Hide resolved
AntoineRelief left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things that don't work as expected:
- in the draft record modal ( when previewing ) we don't see the pages
- I didn't check all in details, but I think some methods that were used to remove temporary records after saving ( for resource / resources questions ) were disabled -> to double check
- the possibility to see draft should also be visible in the modal when adding new records ( from a grid, for example ). It may need to refactor the code, so the button to open the draft is a component ( instead of being a button in the form.component as it is now ).
- when the draft is saved ( not as a draft, but as a record ), the draft is not removed. It should be
| Done:
|
| Done: updated ResourceModalComponent and the survey utils.ts file to always create draft files instead of temporary records with the local storage |
… enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
| @LenaelleRelief @estelafs |
…tions/oort-frontend@v2.2.0-beta.7...v2.2.0-beta.8) (2023-11-09) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets auto sizing grid columns would create tiny columns when too many columns ([#2057](https://github.com/ReliefApplications/oort-frontend/issues/2057)) ([6afea60](ReliefApplications/oort-frontend@6afea60)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets navigate to page action in grid / summary card would limit to only id field ([#2029](https://github.com/ReliefApplications/oort-frontend/issues/2029)) ([12eb046](ReliefApplications/oort-frontend@12eb046)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets readonly would not be correctly considered in resources question ([#2054](https://github.com/ReliefApplications/oort-frontend/issues/2054)) ([498bb96](ReliefApplications/oort-frontend@498bb96)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets some widgets in tab widget could not be resized ([1413948](ReliefApplications/oort-frontend@1413948)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets Ability to save draft record ([#2030](https://github.com/ReliefApplications/oort-frontend/issues/2030)) ([2aeeca1](ReliefApplications/oort-frontend@2aeeca1)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets implement filter icon ([356c39a](ReliefApplications/oort-frontend@356c39a)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets implement filter icon & dashboard filter modern variant ([ed63923](ReliefApplications/oort-frontend@ed63923))

Description
Adds a new feature that allows the user to save draft records and select them to fill a form again.
User story 74319
Ticket 77590
Not a 100% sure I added JSCode everywhere...Sorry
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Screenshots
Checklist:
( * == Mandatory )