Skip to content

Conversation

filipecosta90
Copy link
Contributor

This PR closes the missing gap to fix #30. The map support was already addressed by @AvitalFineRedis on #47 so we just need to support []string type within ToString() function.
Included as a test the use-case raised on #30 by @sankarvj

@filipecosta90 filipecosta90 added the bug Something isn't working label Jun 2, 2021
Copy link
Contributor

@jeffreylovitz jeffreylovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me!

@jeffreylovitz jeffreylovitz merged commit 2a1d063 into master Jun 2, 2021
@jeffreylovitz jeffreylovitz deleted the support.string.slice.params branch June 2, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

2 participants