Skip to content

Conversation

koleini
Copy link

@koleini koleini commented Mar 25, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 1 alert when merging 39fe29a into 3ed59e3 - view on LGTM.com

new alerts:

  • 1 for Unused import
ENV LD_PRELOAD /usr/lib/aarch64-linux-gnu/libgomp.so.1
ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get -qq update
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apt-get -qq update
RUN apt-get -qq update && apt-get install -qqy python3-distutils patch

RUN apt-get -qq update

RUN set -ex ;\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN wget -q https://bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py && python3 /tmp/get-pip.p3


RUN apt-get -qq update && apt-get upgrade -y

RUN set -x; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN apt-get install -yqq curl patch


RUN set -x; \
apt-get install -y curl patch; \
curl https://bootstrap.pypa.io/get-pip.py -o /tmp/get-pip.py ;\
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN wget -q bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py && python3 /tmp/get-pip.p3

Copy link

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes. We should silence the output of apt along the way.

@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2021

This pull request introduces 1 alert when merging 5436ca8 into 3ed59e3 - view on LGTM.com

new alerts:

  • 1 for Unused import
@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2021

This pull request introduces 1 alert when merging 65f1b10 into 3ed59e3 - view on LGTM.com

new alerts:

  • 1 for Unused import
self.install("python3-regex")
self.install("python3-psutil python3-networkx python3-numpy") # python3-skimage
- self.install_git_lfs_on_linux()
+ # self.install_git_lfs_on_linux()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ENV NVIDIA_VISIBLE_DEVICES all
ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

RUN if [ ! -z $(command -v apt-get) ]; then apt-get -qq update; apt-get -q install -y libgomp1 build-essential libatlas-base-dev cmake ; fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using semi-colons (;) to separate commands, try &&. This was if anything within the command fails, it fails.

ENV NVIDIA_DRIVER_CAPABILITIES compute,utility

RUN if [ ! -z $(command -v apt-get) ]; then apt-get -qq update; apt-get -q install -y libgomp1 build-essential libatlas-base-dev cmake ; fi
RUN if [ ! -z $(command -v yum) ]; then yum install -y libgomp; fi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using semi-colons (;) to separate commands, try &&. This was if anything within the command fails, it fails.

Copy link

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-ampersands, and suggested changes. Otherwise stamped.

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2021

This pull request introduces 1 alert when merging adb1a00 into 3ed59e3 - view on LGTM.com

new alerts:

  • 1 for Unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants