enable FT.TAGVALS command #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #94 +/- ## ========================================== + Coverage 91.35% 91.39% +0.04% ========================================== Files 12 12 Lines 1584 1593 +9 ========================================== + Hits 1447 1456 +9 Misses 137 137
Continue to review full report at Codecov.
|
rafie previously approved these changes Oct 7, 2020
ashtul reviewed Oct 7, 2020
Contributor
ashtul left a comment
ashtul left a comment There was a problem hiding this comment.
Thank for the contribution. It looks great!
Just minor comments.
| res = client.search(q) | ||
| self.assertEqual(1, res.total) | ||
| | ||
| q2 = client.tagvals('tags') |
Contributor
There was a problem hiding this comment.
Let's add another document with additional words and see that we get the combined list.
rafie reviewed Oct 7, 2020
| Kudos, SonarCloud Quality Gate passed!
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
add a new function to client which takes the name of a tagfield and runs the following command
Returning a list of tags.
Test is included in test/test.py