Skip to content

Conversation

@gkorland
Copy link
Contributor

repalce NotImplemented with NotImplementedError to avoid type error on python 3

repalce NotImplemented with NotImplementedError to avoid type error on python 3
@gkorland gkorland requested a review from rafie September 18, 2020 18:47
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #90 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #90 +/- ## ========================================== - Coverage 91.43% 91.35% -0.08%  ========================================== Files 12 12 Lines 1587 1584 -3 ========================================== - Hits 1451 1447 -4  - Misses 136 137 +1 
Impacted Files Coverage Δ
redisearch/client.py 88.32% <0.00%> (-0.36%) ⬇️
test/test.py 98.87% <0.00%> (-0.01%) ⬇️
redisearch/aggregation.py 76.19% <0.00%> (+0.14%) ⬆️
redisearch/querystring.py 77.53% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ec721...d84cfe6. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Sep 18, 2020

This pull request fixes 2 alerts when merging 3781f1f into 1873733 - view on LGTM.com

fixed alerts:

  • 2 for NotImplemented is not an Exception
@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2020

This pull request fixes 2 alerts when merging 367feea into 324e147 - view on LGTM.com

fixed alerts:

  • 2 for NotImplemented is not an Exception
@ashtul
Copy link
Contributor

ashtul commented Oct 13, 2020

same fix in #95

@ashtul ashtul closed this Oct 13, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chayim chayim deleted the NotImplementedError branch December 19, 2021 09:37
@chayim chayim restored the NotImplementedError branch December 19, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants