Skip to content

Conversation

@ashtul
Copy link
Contributor

@ashtul ashtul commented Aug 3, 2020

No description provided.

@ashtul ashtul requested a review from gkorland August 3, 2020 08:59
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Small comment.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #77 into master will decrease coverage by 2.46%.
The diff coverage is 58.73%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #77 +/- ## ========================================== - Coverage 90.70% 88.24% -2.47%  ========================================== Files 12 12 Lines 1463 1582 +119 ========================================== + Hits 1327 1396 +69  - Misses 136 186 +50 
Impacted Files Coverage Δ
redisearch/client.py 79.06% <42.30%> (-6.82%) ⬇️
test/test.py 95.30% <69.86%> (-3.84%) ⬇️
redisearch/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a84f3b...dd15037. Read the comment docs.

@ashtul ashtul requested a review from MeirShpilraien August 4, 2020 06:59
@gkorland gkorland merged commit 04b8ea9 into master Aug 4, 2020
@gkorland gkorland deleted the add-wait-for-async branch August 4, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants