Adds the ability to use SORTBY #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dvirsky suggested changes Aug 12, 2017
Contributor
dvirsky left a comment
dvirsky left a comment There was a problem hiding this comment.
Itamar, thanks for this. Beyond the small API change, do provide a test for this.
redisearch/query.py Outdated
| self._filters.append(flt) | ||
| return self | ||
| | ||
| def sortby(self, sortfld): |
Contributor
There was a problem hiding this comment.
the API should be
def sort_by(self, field, asc = True): The internal class should not be intialized by the user.
Contributor
There was a problem hiding this comment.
(do however keep it internally, it's cool)
Contributor Author
| @dvirsky changed the API and added a test. Please note that I also fixed the test for |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please review and release a new version