Skip to content

Fix TextField Sortable/Nostem bug #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Fix TextField Sortable/Nostem bug #44

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5adce78
fix textfield bug
cheeseandcereal Oct 25, 2019
cc2ef1c
Merge branch 'master' into fix_textfield
cheeseandcereal Oct 25, 2019
9d0ea7e
Merge branch 'master' into fix_textfield
gkorland Oct 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions redisearch/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ class TextField(Field):
def __init__(self, name, weight=1.0, sortable=False, no_stem=False,
no_index=False):
args = [Field.TEXT, Field.WEIGHT, weight]
if sortable:
args.append(Field.SORTABLE)
if no_stem:
args.append(self.NOSTEM)
if sortable:
args.append(Field.SORTABLE)
if no_index:
args.append(self.NOINDEX)

Expand Down
16 changes: 16 additions & 0 deletions test/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,22 @@ def testTags(self):
res = client.search(q)
self.assertEqual(1, res.total)

def testTextFieldSortableNostem(self):
conn = self.redis()

with conn as r:
# Creating a client with a given index name
client = Client('sortableNostem', port=conn.port)
client.redis.flushdb()

# Creating the index definition with sortable and no_stem
client.create_index((TextField('txt', sortable=True, no_stem=True),))

# Now get the index info to confirm its contents
response = client.info()
self.assertIn(b'SORTABLE', response['fields'][0])
self.assertIn(b'NOSTEM', response['fields'][0])

if __name__ == '__main__':

unittest.main()