support new features #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Ensure test files are relative to test source - Don't die if index being dropped doesn't already exist
dvirsky suggested changes Jul 11, 2017
redisearch/query.py Outdated
| self._ids = ids | ||
| return self | ||
| | ||
| def returning(self, *fields): |
Contributor
There was a problem hiding this comment.
rename to return_fields please
test/test.py Outdated
| | ||
| | ||
| for doc in client.search(Query('henry king').returning('play', 'nonexist')).docs: | ||
| doc.nonexist |
Contributor
There was a problem hiding this comment.
there is no assertion here
Contributor Author
There was a problem hiding this comment.
This is deliberate. I'm unsure what exactly would be included in the field, but I could be sure that trying to access this field would not result in an exception (e.g. AttributeError)
Contributor
There was a problem hiding this comment.
you do know that doc.nonexist should be None and that doc.play should have content in it
| | ||
| | ||
| class SuggestionParser(object): | ||
| def __init__(self, with_scores, with_payloads, ret): |
Contributor
There was a problem hiding this comment.
Add docstring detailing what this does please.
Contributor Author
| Changes addressed/fixed. |
This adds a `returning()` builder method
dvirsky approved these changes Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.