Support highlighting API #12
Conversation
| actually.. I'm writing tests and there are indeed a few bugs :) |
| self._return_fields = fields | ||
| return self | ||
| | ||
| def summarize(self, *fields, **options): |
There was a problem hiding this comment.
I prefer that the kwargs will have the defaults already. I hate it when python code sends you on an RTFM mission to decipher what **kwargs actually mean...
There was a problem hiding this comment.
The problem with this is that it disallows me from specifying multiple fields, and the user must then do one field at a time. I guess it's acceptable, but annoying.
| self._summarize_fields = args | ||
| return self | ||
| | ||
| def highlight(self, *fields, **options): |
There was a problem hiding this comment.
Again, provide keyword arguments with sane defaults here...
| Looks good besides the **options thing which I would rewrite as defaults. Please also regenerate the docs with Thanks! |
| Using |
Might still need some tests