Remove @NonNull annotation from Collector container type parameter. #7590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`collect` delegates to `FlowableCollectWithCollectorSingle`, which does is not annotated to require a non-nullable type for its corresponding type parameter and whose implementation works fine with a null container. This PR lets Kotlin code pass a `Collector<T, A, R>`, where `A` is declared as `<A: Any?>`.
Codecov Report
@@ Coverage Diff @@ ## 3.x #7590 +/- ## ========================================= Coverage 99.53% 99.53% + Complexity 6802 6801 -1 ========================================= Files 752 752 Lines 47706 47706 Branches 6401 6401 ========================================= + Hits 47482 47484 +2 + Misses 105 99 -6 - Partials 119 123 +4
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor Author
| Wait, did I completely misread this? I need to have another look. Sorry.... |
Contributor Author
| OK, I might have it: I think that this change still makes sense. But I got confused because I was looking at the other overload of Next, I'm going to see if our code could get away with calling the overload that I'm changing in this PR. If it can, then I will still be interested in the PR, since I do think the annotations for this overload are unnecessarily strict. |
Contributor Author
| Yes: Our code can be changed to call this overload. (The code was originally written for RxJava 2, when the |
akarnokd added a commit that referenced this pull request Aug 23, 2023
This was referenced Aug 23, 2023
Merged
Open
Merged
Contributor Author
| Thanks, and thank you for taking care of Observable, too. |
1 task
1 task
Open
1 task
1 task
This was referenced Aug 24, 2023
This was referenced Aug 24, 2023
github-merge-queue bot referenced this pull request in slackhq/circuit Aug 26, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
github-merge-queue bot referenced this pull request in slackhq/foundry Aug 28, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
ashdavies referenced this pull request in ashdavies/circuit Sep 14, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
This was referenced Sep 16, 2023
Closed
1 task
nikclayton referenced this pull request in pachli/pachli-android Sep 27, 2023
…107) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | `3.1.6` -> `3.1.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
1 task
connyduck referenced this pull request in tuskyapp/Tusky Jan 3, 2024
…4092) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | `3.1.6` -> `3.1.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.8`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.8) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.8%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.8) ##### Bugfixes - Fix `ObservableSwitchMap` `NullPointerException` due to cancel race. ([https://github.com/ReactiveX/RxJava/pull/7597](https://togithub.com/ReactiveX/RxJava/pull/7597)) ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tuskyapp/Tusky). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Merged
1 task
1 task
Merged
1 task
1 task
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
collectdelegates toFlowableCollectWithCollectorSingle, whichis not annotated to require a non-nullable type for its corresponding
type parameter and whose implementation works fine with a null
container.
This PR lets Kotlin code pass a
Collector<T, A, R>, whereAisdeclared as
<A: Any?>.