3.x: Remove fixPom method from build.gradle #7253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The pom is generated with the reactive-streams scope set to 'compile' by default. To test that this works, the below gradle tasks were run: ./gradlew -PreleaseMode=full cleanGeneratePomFileForMavenPublication generatePomFileForMavenPublication ./gradlew -PreleaseMode=branch cleanGeneratePomFileForMavenPublication generatePomFileForMavenPublication Both tasks generated a pom file with the reactive-streams set to 'compile' scope.
Codecov Report
@@ Coverage Diff @@ ## 3.x #7253 +/- ## ========================================= Coverage 99.53% 99.54% + Complexity 6759 6758 -1 ========================================= Files 747 747 Lines 47391 47391 Branches 6382 6382 ========================================= + Hits 47169 47173 +4 - Misses 99 100 +1 + Partials 123 118 -5 Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The pom is generated with the reactive-streams scope set to 'compile' based on it being set to 'api' in dependencies. I'm assuming this was fixed at some point previously, so the fixPom method is no longer needed.
To test that this works, the below gradle tasks were run:
./gradlew -PreleaseMode=full cleanGeneratePomFileForMavenPublication generatePomFileForMavenPublication
./gradlew -PreleaseMode=branch cleanGeneratePomFileForMavenPublication generatePomFileForMavenPublication
Both tasks generated a pom file with the reactive-streams set to
'compile' scope.