Skip to content

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 3, 2021

The direct scheduling methods of the ExecutorScheduler created via Schedulers.from(Executor, boolean) did not fully honor the interruptibleWorker settings.

Fixes #7201

@akarnokd akarnokd added this to the 3.1 milestone Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #7203 (e9af0e6) into 3.x (a4e087d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## 3.x #7203 +/- ## ============================================ - Coverage 99.54% 99.51% -0.04%  Complexity 6757 6757 ============================================ Files 747 747 Lines 47387 47392 +5 Branches 6384 6382 -2 ============================================ - Hits 47170 47160 -10  - Misses 99 106 +7  - Partials 118 126 +8 
Impacted Files Coverage Δ Complexity Δ
...xjava3/internal/schedulers/AbstractDirectTask.java 100.00% <100.00%> (ø) 21.00 <3.00> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java 100.00% <100.00%> (ø) 10.00 <0.00> (ø)
...x/rxjava3/internal/schedulers/NewThreadWorker.java 94.91% <100.00%> (ø) 19.00 <2.00> (ø)
...ternal/schedulers/ScheduledDirectPeriodicTask.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java3/internal/schedulers/ScheduledDirectTask.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...x/rxjava3/internal/schedulers/SingleScheduler.java 97.59% <100.00%> (ø) 15.00 <2.00> (ø)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 93.57% <0.00%> (-2.76%) 2.00% <0.00%> (ø%)
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-2.39%) 2.00% <0.00%> (ø%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.85% <0.00%> (-2.08%) 2.00% <0.00%> (ø%)
...reactivex/rxjava3/processors/PublishProcessor.java 98.16% <0.00%> (-1.84%) 41.00% <0.00%> (-1.00%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e087d...30ac31b. Read the comment docs.

@akarnokd akarnokd merged commit 26dddf5 into ReactiveX:3.x Mar 5, 2021
@akarnokd akarnokd deleted the SchedulerFromInterruptWithSE branch March 5, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant