3.x: Remove unnecessary cancel/dispose calls from terminating using #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## 3.x #7121 +/- ## ============================================ + Coverage 99.49% 99.53% +0.04% + Complexity 6670 6669 -1 ============================================ Files 742 742 Lines 47275 47267 -8 Branches 6374 6374 ============================================ + Hits 47037 47048 +11 + Misses 112 100 -12 + Partials 126 119 -7 Continue to review full report at Codecov.
|
vanniktech approved these changes Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Following up on a Gitter.im report, the
onComplete/onErrormethods of theusingoperators were calling cancel/dispose on the upstream even though there is no reason to do such a thing and is also not allowed by Reactive Streams rule 2.3.The original code's side-effect was that given a nested
usingpair, anonComplete/onErrorof the inner sequence would trigger a cancellation and resource release in the outer before/while theonComplete/onErrorsignals propagate downstream and return back on a non-eager setting.