3.x: Fix Observable.window (size, skip, overlap) dispose behavior #7049
+208 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## 3.x #7049 +/- ## ============================================ - Coverage 99.52% 99.51% -0.02% + Complexity 6669 6667 -2 ============================================ Files 742 742 Lines 47273 47275 +2 Branches 6374 6374 ============================================ - Hits 47048 47045 -3 - Misses 105 107 +2 - Partials 120 123 +3 Continue to review full report at Codecov.
|
vanniktech reviewed Aug 6, 2020
Collaborator
vanniktech left a comment
vanniktech left a comment There was a problem hiding this comment.
Whops. Somehow missed this 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Disposing the main output of the
Observable.windowoperator did not properly propagate the dispose call under certain circumstances, such as no current active window or the window(s) were abandoned immediately.Fixes #7048