Skip to content

Conversation

@VovaStelmashchuk
Copy link
Contributor

@VovaStelmashchuk VovaStelmashchuk commented Mar 14, 2020

@akarnokd akarnokd added this to the 3.1 milestone Mar 14, 2020
@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #6934 into 3.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## 3.x #6934 +/- ## ============================================ - Coverage 99.68% 99.62% -0.07%  + Complexity 6668 6664 -4  ============================================ Files 742 742 Lines 47220 47220 Branches 6367 6367 ============================================ - Hits 47071 47042 -29  - Misses 45 56 +11  - Partials 104 122 +18 
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø) 595.00 <0.00> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø) 565.00 <0.00> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 95.14% <0.00%> (-4.21%) 6.00% <0.00%> (ø%)
.../operators/observable/ObservableFlatMapSingle.java 96.03% <0.00%> (-2.39%) 2.00% <0.00%> (ø%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.34% <0.00%> (-2.33%) 2.00% <0.00%> (ø%)
.../internal/disposables/ListCompositeDisposable.java 98.00% <0.00%> (-2.00%) 34.00% <0.00%> (-1.00%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0.00%> (-1.86%) 39.00% <0.00%> (-1.00%)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 91.74% <0.00%> (-1.84%) 2.00% <0.00%> (ø%)
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0.00%> (-1.39%) 57.00% <0.00%> (-1.00%)
...ava3/internal/operators/maybe/MaybeMergeArray.java 98.87% <0.00%> (-1.13%) 6.00% <0.00%> (ø%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd496db...cd6989f. Read the comment docs.

@VovaStelmashchuk
Copy link
Contributor Author

I think about add all range methods to javadoc of each range method. @akarnokd Do this have a sense?

@akarnokd
Copy link
Member

Don't overdo it.

@akarnokd akarnokd merged commit f863a4e into ReactiveX:3.x Mar 19, 2020
@VovaStelmashchuk VovaStelmashchuk deleted the add_see_to_range_operators branch March 19, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants