3.x: Change Flowable.groupBy to signal MBE instead of possibly hanging #6740
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes the backpressure behavior of
Flowable.groupBy
to signalMissingBackpressureException
instead of silently hanging if the produced groups are not ready to be accepted by the downstream.This can happen if one
flatMap
s agroupBy
but there are more groups produced than the concurrency level offlatMap
. Since replenishment is tied to item consumption from the groups, not consuming them can result in none of the groups receiving any further items and the whole operator hangs.The following changes have been applied:
Flowable
, lacking a queue, no longer supports operator fusion. Tests checking this property have been removed as well.pull
,isEmpty
andclear
will trigger replenishment so that other groups can make progress too.Fixes #6641