Skip to content

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Nov 8, 2019

Add rule to ignore java.util.concurrent.Flow* when using Android's R8 to prevent warnings about the FlowAdapter.class contained within the Reactive Streams JAR file.

@akarnokd akarnokd added this to the 3.0 milestone Nov 8, 2019
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #6706 into 3.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## 3.x #6706 +/- ## =========================================== - Coverage 98.12% 98.1% -0.03%  - Complexity 6187 6190 +3  =========================================== Files 677 677 Lines 44657 44657 Branches 6170 6170 =========================================== - Hits 43821 43810 -11  - Misses 301 307 +6  - Partials 535 540 +5
Impacted Files Coverage Δ Complexity Δ
.../operators/observable/ObservableFlatMapSingle.java 88.88% <0%> (-6.35%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 94.17% <0%> (-2.92%) 6% <0%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.14% <0%> (-2.12%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 95.94% <0%> (-1.36%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
...a3/internal/operators/flowable/FlowableReplay.java 91.97% <0%> (-0.83%) 19% <0%> (ø)
...ternal/operators/observable/ObservableGroupBy.java 95.08% <0%> (-0.55%) 2% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 89.96% <0%> (-0.34%) 3% <0%> (ø)
...internal/operators/flowable/FlowableObserveOn.java 96.65% <0%> (-0.28%) 3% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 96.55% <0%> (ø) 3% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b6d7b...e3c8776. Read the comment docs.

@akarnokd akarnokd merged commit 1e7abf2 into ReactiveX:3.x Nov 8, 2019
@akarnokd akarnokd deleted the ProGuard3x branch November 8, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants