3.x: Refactor to io.reactivex.rxjava3.** #6621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## 3.x #6621 +/- ## ====================================== Coverage ? 98.19% Complexity ? 6191 ====================================== Files ? 678 Lines ? 44792 Branches ? 6173 ====================================== Hits ? 43982 Misses ? 278 Partials ? 532Continue to review full report at Codecov.
|
| You can compare lines and branch counts: #6620 (comment) @@ Coverage Diff @@ ## 3.x #6620 +/- ## ============================================ + Coverage 98.13% 98.17% +0.03% - Complexity 6187 6188 +1 ============================================ Files 678 678 Lines 44792 44792 Branches 6173 6173 ============================================ + Hits 43956 43973 +17 + Misses 290 281 -9 + Partials 546 538 -8 |
| Go ahead and merge! |
| | ||
| def junitVersion = "4.12" | ||
| def reactiveStreamsVersion = "1.0.2" | ||
| def reactiveStreamsVersion = "1.0.3-RC1" |
There was a problem hiding this comment.
Prob should have been done in a separate PR, but not a big deal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR refactors the package structure to match the group ID:
io.reactivex.rxjava3. In addition, the base classes and interfaces now live inio.reactivex.rxjava3.core.In addition, the Reactive Streams dependency was bumped to 1.0.3-RC1 to verify the TCK changes.