3.x: Make using() resource disposal order consistent with eager-mode #6534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
70 tasks
Codecov Report
@@ Coverage Diff @@ ## 3.x #6534 +/- ## ============================================ + Coverage 98.21% 98.24% +0.03% - Complexity 6189 6190 +1 ============================================ Files 680 680 Lines 44883 44905 +22 Branches 6193 6198 +5 ============================================ + Hits 44081 44118 +37 + Misses 261 249 -12 + Partials 541 538 -3
Continue to review full report at Codecov.
|
This was referenced Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make the resource disposal order in all
usingimplementations are consistent with the eagerness of the operator:eager: dispose resource then dispose the upstream
non-eager: dispose the upstream then dispose the resource.
Fixes: #6347