Sync HandlerScheduler error handling with RxJava impl. #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vanniktech approved these changes Aug 16, 2017
artem-zinnatullin deleted the az/sync-scheduler-error-handler-with-rxjava branch 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR syncs error handling of
HandlerSchedulerwith error handling of RxJava schedulers by simply delivering exception as is to the RxJavaPlugins' error handler.RxJavaPlugins not only delivers exception to the
Thread.UncaughtExceptionHandlerby default, but also allows user to actually override and customize this behavior.Current RxAndroid implementation delivers exception to
UncaughtExceptionHandlerunconditionally.Resolves #390.
@akarnokd, @JakeWharton PTAL