Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • fix unity hub cli editor output capture
  • updated version parsing
  • added unit tests
- fix unity hub cli editor output capture - updated version parsing - added unit tests
@StephenHodgson StephenHodgson marked this pull request as ready for review August 25, 2025 18:55
Copilot AI review requested due to automatic review settings August 25, 2025 18:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces version 1.2.5 of the Unity setup action with significant improvements to Unity Hub CLI editor output parsing and version resolution. The changes focus on better handling of Unity version patterns, wildcards, and partial version specifications while ensuring compatibility with both Hub CLI output and Unity's releases API.

  • Improved Unity Hub CLI output capture to handle different formats returned by Unity Hub
  • Enhanced version parsing logic to support major-only and partial version specifications
  • Added comprehensive unit tests covering version matching and fallback scenarios

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/unity-version.test.ts Comprehensive test suite for version matching and fallback scenarios
src/unity-version.ts Enhanced version matching logic with improved fallback handling
src/unity-hub.ts Better Unity Hub CLI output parsing and version resolution
src/inputs.ts Updated input normalization to preserve major-only version patterns
package.json Version bump to 1.2.5 and dependency updates
.github/workflows/build.yml Enhanced CI validation for version matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StephenHodgson StephenHodgson merged commit 58c2adc into main Aug 26, 2025
26 checks passed
@StephenHodgson StephenHodgson deleted the development branch August 26, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants