Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

Conversation

artisticat1
Copy link
Collaborator

This PR improves some of the css styling. It fixes misaligned icons, the gap after the headings causing misaligned columns, invisible text, etc. It also changes the popovers to use the menu css class in obsidian, so that they get styled by themes.

Here's what the plugin looks like before:
before

and after:
after

It also works well with all other themes I tested:
minimal-after

I'm not familiar with react, so let me know if I made any bad choices!

@RafaelGB
Copy link
Owner

RafaelGB commented May 8, 2022

@artisticat1 OMG nice work!
As a backend developer the style is not my best skill. Thanks for your contribution

I will test it and merge as soon as posible

@RafaelGB RafaelGB assigned RafaelGB and artisticat1 and unassigned RafaelGB May 8, 2022
@RafaelGB RafaelGB added the Visual Visual problem of the application label May 8, 2022
onChange(e.target.value);
}}
placeholder={`${count} records...`}
style={{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About this erase of style. It is necessary to lose the background property?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all the styling (including the background property) since it'd be handled by the styling of input[type=search] in the user's theme.

@@ -1,312 +1,326 @@
@import url("https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600;700&display=swap");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the real differences well. All the file looks modified. I thinks its my fault because I don't have the prettier enabled with css.

I added few things with 0.2.1 release. padding but I will merge and add again =) thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oops! VScode didn't show me any of these changes when I was committing.

Copy link
Owner

@RafaelGB RafaelGB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learnt a lot with your contribution. Thank you again

@RafaelGB RafaelGB merged commit d8b61fa into RafaelGB:master May 8, 2022
@RafaelGB
Copy link
Owner

RafaelGB commented May 8, 2022

Your contribution was tested and will be added with 0.3.0

I am working with PR feedback of the official release. Your add button align fixed one of the dots =)

@artisticat1
Copy link
Collaborator Author

Your contribution was tested and will be added with 0.3.0

I am working with PR feedback of the official release. Your add button align fixed one of the dots =)

Awesome! Glad I could help :D Thanks for the plugin!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Visual Visual problem of the application

2 participants