- Notifications
You must be signed in to change notification settings - Fork 5.3k
[sdio][dm] update for DM #11078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[sdio][dm] update for DM #11078
Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
1. Support features read by DM. 2. Support regulator API in drivers. 3. Support send tuning option CMD. 4. Replace `switch_uhs_voltage` by `signal_voltage_switch`. Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
1. SDHCI support on PCI bus 2. Synopsys DesignWare MMC Family(MMIO/PCI) Signed-off-by: GuEe-GUI <2991707448@qq.com>
| 👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-22 13:44 CST)
📝 Review Instructions
|
| @helloeagleyang 可以来看看 |
单纯从改动上看,没有啥问题 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the SDIO/SDHCI subsystem to support Device Manager (DM) mode, adds new drivers, and refactors existing code. The main changes include:
- Cleanup of old SDHCI header files and reorganization of code structure
- Introduction of DM support with new abstraction layers (dev_sdio_dm.c/h, dev_sdhci_dm.c/h)
- Addition of new SDIO/SDHCI drivers: SDHCI-PCI, SDIO-DW (DesignWare MMC) for platform and PCI
- API modernization: replacing
switch_uhs_voltagewithsignal_voltage_switchand adding signal voltage support - New regulator API support for power management
- Addition of tuning command support (mmcsd_send_tuning, mmcsd_send_abort_tuning)
- Configuration updates with new Kconfig options and updated stack size defaults
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| components/drivers/sdio/sdhci/include/*.h | Removed old SDHCI headers (cleanup) |
| components/drivers/sdio/dev_sdio_dm.[ch] | New DM abstraction layer for SDIO |
| components/drivers/sdio/dev_sdhci_dm.[ch] | New DM abstraction layer for SDHCI |
| components/drivers/sdio/dev_sdhci_host.c | Refactored to use DM APIs and container_of pattern |
| components/drivers/sdio/host/* | New host drivers: sdio-dw, sdhci-pci |
| components/drivers/sdio/dev_regulator.c | New regulator support for voltage control |
| components/drivers/sdio/dev_mmcsd_core.c | Added voltage switch and tuning functions |
| components/drivers/sdio/dev_sd.c | Updated to use new signal_voltage_switch API |
| components/drivers/sdio/Kconfig | Updated with DM options and stack size defaults |
| components/drivers/sdio/SConscript | Reorganized build configuration |
| bsp/hpmicro/libraries/drivers/drv_sdio.c | Updated to use new signal_voltage_switch API |
拉取/合并请求描述:(PR description)
[
switch_uhs_voltagebysignal_voltage_switch.]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up