Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Apr 17, 2024

This PR migrates the relevant sections of _static/lecture_specific/graphviz to be contained in figures.ipynb notebooks in

  • markov_chains_I
  • markov_chains_II
  • networks
  • lake_model

so the figures are directly associated with the lectures in which they appear.

This commits both the png asset and the text tikz output.

Fixes #422

@netlify
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 2077d93
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6625cba2e30cf700086d89ce
😎 Deploy Preview https://deploy-preview-424--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky mmcky marked this pull request as ready for review April 17, 2024 05:57
@mmcky mmcky requested review from HumphreyYang and kp992 April 17, 2024 05:57
@github-actions
Copy link

github-actions bot commented Apr 17, 2024

@github-actions github-actions bot temporarily deployed to pull request April 17, 2024 06:05 Inactive
Copy link
Contributor

@kp992 kp992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmcky, this looks great!

@mmcky mmcky requested a review from jstac April 22, 2024 02:24
@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2024

@jstac this is ready for your final review and merge.

@jstac
Copy link
Contributor

jstac commented Apr 22, 2024

Many thanks @mmcky , much appreciated. Please merge when ready.

@github-actions github-actions bot temporarily deployed to pull request April 22, 2024 02:38 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 22, 2024

  • checked paths in the lectures for graphviz and doesn't appear to be referenced. Merging this now.
@mmcky mmcky merged commit c879389 into main Apr 22, 2024
@mmcky mmcky deleted the refactor-graphviz branch April 22, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants