Skip to content

Conversation

@HumphreyYang
Copy link
Member

This PR migrates duplicate lectures in #282

@netlify
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 212d6be
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65c019ec546fc40008e1400d
😎 Deploy Preview https://deploy-preview-340--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jan 29, 2024

```{index} single: Dynamic Programming; Shortest Paths
```

```{contents} Contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang we should remove these content blocks as they are not required. The theme builds a RHS toc in the margin.

@HumphreyYang
Copy link
Member Author

Hi @mmcky,

Many thanks for letting me know.

I have removed both content tags in geom_series and short_path. There is no other content tags in this series based on a global search.

@mmcky
Copy link
Contributor

mmcky commented Feb 1, 2024

@HumphreyYang looks like we just need to update a link

/home/runner/work/lecture-python-intro/lecture-python-intro/lectures/complex_and_trig.md:39: WARNING: unknown document: samuelson 
@HumphreyYang
Copy link
Member Author

Many thanks @mmcky,

This is linked to a lecture in the intermediate series.

Should I link it to our new migrated series or the intermediate series?

@HumphreyYang
Copy link
Member Author

Hi @mmcky,

Please let me know your thoughts on this when you are available:

This is linked to a lecture in the intermediate series.

Should I link it to our new migrated series or the intermediate series?

@mmcky
Copy link
Contributor

mmcky commented Feb 4, 2024

thanks @HumphreyYang

Should I link it to our new migrated series or the intermediate series?

This should be linked to the new migrated (topic based series)

@HumphreyYang HumphreyYang mentioned this pull request Feb 4, 2024
@HumphreyYang
Copy link
Member Author

Hi @mmcky,

I think this is ready for your review now.

@mmcky mmcky self-requested a review February 4, 2024 23:26
@mmcky mmcky merged commit dfd749d into main Feb 4, 2024
@mmcky mmcky deleted the migrate-tags branch February 4, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants