long_run_growth: styling and label fixes #328
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| thanks @kp992 I will ask @HumphreyYang to review as he recently edited this lecture. |
There was a problem hiding this comment.
Many thanks @kp992! It looks great. Just two very small comments. Please let me know your thoughts.
thanks @kp992 I will ask @HumphreyYang to review as he recently edited this lecture.
(I think I edited the inflation lecture instead of long_run_growth) : )
lectures/long_run_growth.md Outdated
| | ||
| ```{code-cell} ipython3 | ||
| BEM = ['GBR', 'IND', 'AUS', 'NZL', 'CAN', 'ZAF'] | ||
| gdp['BEM'] = gdp[BEM].loc[start_year-1:end_year].interpolate(method='index').sum(axis=1) # Interpolate incomplete time-series |
There was a problem hiding this comment.
I think this line is also a bit too long. I suggest we can cut it to this:
| gdp['BEM'] = gdp[BEM].loc[start_year-1:end_year].interpolate(method='index').sum(axis=1) # Interpolate incomplete time-series | |
| # Interpolate incomplete time-series | |
| gdp['BEM'] = gdp[BEM].loc[start_year-1:end_year].interpolate(method='index').sum(axis=1) |
lectures/long_run_growth.md Outdated
| | ||
| ```{code-cell} ipython3 | ||
| gdp['BEM'].plot() # The first year is np.nan due to interpolation | ||
| gdp['BEM'].plot(ylabel="International $'s") # The first year is np.nan due to interpolation |
There was a problem hiding this comment.
This line prints out the label
We can suppress printing using
| gdp['BEM'].plot(ylabel="International $'s") # The first year is np.nan due to interpolation | |
| _ = gdp['BEM'].plot(ylabel="International $'s") # The first year is np.nan due to interpolation |
or
| gdp['BEM'].plot(ylabel="International $'s") # The first year is np.nan due to interpolation | |
| gdp['BEM'].plot(ylabel="International $'s") # The first year is np.nan due to interpolation | |
| plt.show() |
There was a problem hiding this comment.
thanks @kp992 and @HumphreyYang I think these are good changes.
| thanks @kp992 and @HumphreyYang. This PR just adjusts the spacing of the code to improve readability. I don't see any changes to labels -- is that right? |
I think there is only one change in the label at L510. |
Thanks @HumphreyYang nice find. 👍 |
| @thomassargent30 I am merging this as mainly improving the formatting in the |
| Thanks @mmcky and @HumphreyYang |
3 participants
Fixes #291