Skip to content

Conversation

@HumphreyYang
Copy link
Member

This PR resolves #323.

@netlify
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 0bbafbc
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/657a480ed21f3c00085d1fd0
😎 Deploy Preview https://deploy-preview-324--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Nov 20, 2023

@mmcky
Copy link
Contributor

mmcky commented Nov 20, 2023

thanks @HumphreyYang just confirming that many of the changes listed in the diff are just re-formatting lines to be within the 80 character width?

@HumphreyYang
Copy link
Member Author

HumphreyYang commented Nov 20, 2023

Many thanks @mmcky,

thanks @HumphreyYang just confirming that many of the changes listed in the diff are just re-formatting lines to be within the 80 character width?

Yes, there are many long variable names in the dataset and matplotlib parameters : )

Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HumphreyYang Just one minor typo added as a suggestion.

Co-authored-by: mmcky <mmcky@users.noreply.github.com>
@HumphreyYang
Copy link
Member Author

Many thanks @mmcky! I have committed your suggestion.

@mmcky
Copy link
Contributor

mmcky commented Dec 14, 2023

thanks @HumphreyYang these are great changes and I agree with #323 to remove the tables. Merging this as it addresses all comments from @jstac in #323

  • validate graphs are the same
@mmcky mmcky merged commit 6db9dcd into main Dec 14, 2023
@mmcky mmcky deleted the update_inf_hist branch December 14, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants