Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Jul 6, 2023

This incorporates updates to

  • dark mode
  • search

  • review if search results are OK to send out but @AakashGfude is working on improvements
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit fedbb38
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/64af8150b65fd60008589e93
😎 Deploy Preview https://deploy-preview-265--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

@mmcky
Copy link
Contributor Author

mmcky commented Jul 6, 2023

@AakashGfude search results are hard to see in dark mode

@AakashGfude
Copy link
Member

@AakashGfude search results are hard to see in dark mode

working on it.

@AakashGfude
Copy link
Member

@mmcky this should fix it, if you want to give it a second set of eyes: QuantEcon/quantecon-book-theme#219

@mmcky mmcky changed the title ENH: Upgrade theme to 0.5.2 ENH: Upgrade theme to 0.5.3 Jul 13, 2023
@mmcky
Copy link
Contributor Author

mmcky commented Jul 13, 2023

thanks @AakashGfude definitely an improvement.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 13, 2023

@HengchengZhang would you mind to look over the netlify version and let us know what you think of the new theme updates. Thanks.

@HengchengZhang
Copy link
Member

HengchengZhang commented Jul 13, 2023

Hi @mmcky the new theme looks good in the math equations but I think we can also improve the code part as well if it's not too hard.

And I can also see there are improvements in searchwhich I'm not sure what this is.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 13, 2023

Search is the new feature to search the site from the top toolbar.

Thanks @HengchengZhang

@AakashGfude
Copy link
Member

Hi @mmcky the new theme looks good in the math equations but I think we can also improve the code part as well if it's not too hard.

Thanks @HumphreyYang , are you talking about code in dark mode? Let me know your ideas.

Copy link
Member

@HengchengZhang HengchengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The Python code in dark mode is not using the same color set as other editors do (like VScode or Pycharm) but that's okay.
  • When clicking the search bar it will automatically scroll up a little and then if you keep using key broad (typing in and deleting) it will scroll up one line for each keyboard interaction.
  • The search bar can't search the hidden codes and solutions and I think it's a nice feature if this is intentionally added.
@AakashGfude
Copy link
Member

* When clicking the search bar it will automatically scroll up a little and then if you keep using key broad (typing in and deleting) it will scroll up one line for each keyboard interaction. 

Ooh, I am not able to replicate this. can you make a short clip of it?

@HengchengZhang
Copy link
Member

Thanks @AakashGfude I sent my screen recording to your anu email via onedrive and this link should also work.

@AakashGfude
Copy link
Member

AakashGfude commented Jul 13, 2023

Thanks @HengchengZhang for sharing the video, this is really odd. I will have a look. Is that safari? Can you quickly check if its happening in other browsers as well? Thanks.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 27, 2023

@AakashGfude I will wait until another round of the theme before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants