-
-
Couldn't load subscription status.
- Fork 26
ENH: Upgrade theme to 0.5.3 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @AakashGfude search results are hard to see in |
working on it. |
| @mmcky this should fix it, if you want to give it a second set of eyes: QuantEcon/quantecon-book-theme#219 |
| thanks @AakashGfude definitely an improvement. |
| @HengchengZhang would you mind to look over the netlify version and let us know what you think of the new theme updates. Thanks. |
| Hi @mmcky the new theme looks good in the math equations but I think we can also improve the code part as well if it's not too hard. And I can also see there are improvements in |
| Search is the new feature to search the site from the top toolbar. Thanks @HengchengZhang |
Thanks @HumphreyYang , are you talking about code in dark mode? Let me know your ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The Python code in dark mode is not using the same color set as other editors do (like VScode or Pycharm) but that's okay.
- When clicking the search bar it will automatically scroll up a little and then if you keep using key broad (typing in and deleting) it will scroll up one line for each keyboard interaction.
- The search bar can't search the hidden codes and solutions and I think it's a nice feature if this is intentionally added.
Ooh, I am not able to replicate this. can you make a short clip of it? |
| Thanks @AakashGfude I sent my screen recording to your anu email via onedrive and this link should also work. |
| Thanks @HengchengZhang for sharing the video, this is really odd. I will have a look. Is that safari? Can you quickly check if its happening in other browsers as well? Thanks. |
| @AakashGfude I will wait until another round of the theme before merging. |
This incorporates updates to