Skip to content

Conversation

@shlff
Copy link
Member

@shlff shlff commented Jun 1, 2023

Hi @jstac this PR fixes some typos in the lecture intro_supply_demand.

@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit d1885f2
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/647ab1073eccb800087b6ce2
😎 Deploy Preview https://deploy-preview-213--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jstac
Copy link
Contributor

jstac commented Jun 1, 2023

Thanks @shlff .

The build error says " Executing notebook failed: CellExecutionError". Could you please look into it?

@shlff
Copy link
Member Author

shlff commented Jun 1, 2023

Sure thanks @jstac . I inspected the error log file and found the error arises from the lecture networks:

/home/runner/work/lecture-python-intro/lecture-python-intro/lectures/networks.md: WARNING: Executing notebook failed: CellExecutionError [mystnb.exec] /home/runner/work/lecture-python-intro/lecture-python-intro/lectures/networks.md: WARNING: Notebook exception traceback saved in: /home/runner/work/lecture-python-intro/lecture-python-intro/_build/html/reports/networks.err.log [mystnb.exec] 

The specific error inside that lecture occurred while executing a cell using a file called adjacency_matrix_2019generated using the package quantecon-book-networks

[0;31mKeyError�[0m: 'adjacency_matrix_2019' KeyError: 'adjacency_matrix_2019' 

but the file name there is changed to adjacency_matrix_31-12-2022 with the data updated recently (cc'd @HengchengZhang):

https://github.com/QuantEcon/quantecon-book-networks/blob/c8fdd90b72f087d75d5fe32ed8f35a7cf32b76c0/quantecon_book_networks/data.py#L172-L174

Also in the repo quantecon-book-networks there is a PR intended to change the name adjacency_matrix_31-12-2022 to adjacency_matrix:

@shlff
Copy link
Member Author

shlff commented Jun 1, 2023

I suggest we create an issue to inspect and align the code in lectures that use the package quantecon-book-networks.

@jstac
Copy link
Contributor

jstac commented Jun 1, 2023

Thanks @shlff . Pinging @HengchengZhang and @mmcky .

@HengchengZhang
Copy link
Member

HengchengZhang commented Jun 1, 2023

Hi @shlff thanks for pointing this out.

@HumphreyYang also mentioned this yesterday and we had a discussion through email, that’s why there is a new PR trying to remove the time-sensitive strings in variable and path names. (Since we are likely to update the datasets in future and we don’t want to do the same thing next time.)

I also talked to Humphrey about any further influences besides this lecture and we confirmed this should be the only affected lecture. (That’s why I’m pinging Humphrey in that PR.)

One small thing is that the variable name that currently works should be adjacency_matrix_2022, the one you mentioned is the file name. And that PR is trying to make it to adjacency _matrix.

I will keep an eye on this PR when the qbn package is updated.

@shlff shlff force-pushed the update_intro_sd branch from 32e7b9d to d1885f2 Compare June 3, 2023 03:18
@shlff
Copy link
Member Author

shlff commented Jun 3, 2023

Thanks @HengchengZhang and @Smit-create .

Hi @jstac I updated this PR with the most recent main branch which fixes the error.

This PR is ready for review.

@jstac
Copy link
Contributor

jstac commented Jun 3, 2023

Nice work @shlff , many thanks.

@jstac jstac merged commit dd9f006 into main Jun 3, 2023
@jstac jstac deleted the update_intro_sd branch June 3, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants