Skip to content

Conversation

@maanasee
Copy link
Contributor

Hi @jstac this lecture is ready for review.

@netlify
Copy link

netlify bot commented May 10, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 24f1491
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/645f835c9264b70007dbd315
😎 Deploy Preview https://deploy-preview-194--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jstac
Copy link
Contributor

jstac commented May 12, 2023

@HumphreyYang If you have time, could you please do a first review?

Or @HengchengZhang ?

```{code-cell} ipython3
:tags: [hide-cell]
A, F = build_coefficient_matrices(Z, X)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maanasee,

Many thanks for the great lecture!

I fixed a small bug here as A was overwritten by the small A defined above, which was also causing errors when drawing the bar chart.

Please kindly check the output to see if they are what you expected :)

```{code-cell} ipython3
tags: [hide-input]
:tags: [hide-cell]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstac,

I noticed that you changed [hide-input] to [hide-cell]. I reverted this because [hide-cell] not only hides the code cell but also hides the graph generated from the code : )

Please let me know if this needs further changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HumphreyYang -- I was tired so making mistakes :-)

@jstac
Copy link
Contributor

jstac commented May 13, 2023

@HumphreyYang I really appreciate you jumping in and fixing this at short notice! I'll go ahead and merge so that Tom can edit more easily.

@jstac jstac merged commit f032d17 into main May 13, 2023
@jstac jstac deleted the input_output branch May 13, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants