Skip to content

[inequality] fix_titles #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2023
Merged

[inequality] fix_titles #152

merged 4 commits into from
Apr 13, 2023

Conversation

@shlff
Copy link
Member

@shlff shlff commented Apr 10, 2023

Hi @jstac this PR updates the lecture inequality according to the criteria mentioned in #149 .
@netlify
Copy link

netlify bot commented Apr 10, 2023 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit cadb543
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/64374b39f1349e0008365802
😎 Deploy Preview https://deploy-preview-152--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
@github-actions github-actions bot temporarily deployed to commit April 10, 2023 14:48 Inactive
@shlff
Copy link
Member Author

shlff commented Apr 10, 2023

The FutureWarnings needs to be fixed:
@github-actions github-actions bot temporarily deployed to commit April 13, 2023 00:01 Inactive
@shlff
Copy link
Member Author

shlff commented Apr 13, 2023

The FutureWarnings needs to be fixed:

Fix FutureWarnning mentioned.

Hi @jstac this PR is ready for review.
jstac
jstac reviewed Apr 13, 2023
View reviewed changes
lectures/inequality.md Outdated
mystnb:
figure:
caption: "Shaded Lorenz curves (simulated data) \n"
caption: "Shaded lorenz curve of simulated data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lorenz -> Lorenz
jstac
jstac reviewed Apr 13, 2023
View reviewed changes
lectures/inequality.md Outdated
```

**TEST ===>** Here is a {ref}`gini_us` and a {numref}`gini_us`
**TEST ===>** Here is a {ref}`gini_income_us` and a {numref}`gini_income_us`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed now?
@jstac
Copy link
Contributor

jstac commented Apr 13, 2023

Nice work @shlff , please see the minor comments above.
@github-actions github-actions bot temporarily deployed to commit April 13, 2023 00:33 Inactive
@shlff
Copy link
Member Author

shlff commented Apr 13, 2023

Nice work @shlff , please see the minor comments above.

Thanks for your helpful comments @jstac .

I've made the changes as suggested, and please find the preview attached:
@jstac
Copy link
Contributor

jstac commented Apr 13, 2023

Thanks @shlff , nice work.
@jstac jstac merged commit 42031d9 into main Apr 13, 2023
@jstac jstac deleted the inequality_update branch April 13, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready

3 participants

@shlff @jstac