chore: Add Enhanced Method Query Validation and Tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…or handling - Updated the `clone` method in `PySpringModel` to use the `Self` type hint for better type inference in subclasses. - Enhanced `get_primary_key_columns` to raise a clear error if the table is not found in metadata. - Added comprehensive tests for `PySpringModel` in `tests/test_py_spring_model.py` to verify engine, metadata, connection, and session management functionalities, as well as model cloning.
…ueryBuilder` - Added validation in `_MetodQueryBuilder` to ensure the method name starts with one of the following prefixes: `get_by`, `find_by`, `find_all_by`, or `get_all_by`. Raises a `ValueError` if the prefix is invalid. - Updated `parse_query` method to handle cases where no valid pattern is matched. - Introduced a new test suite `test_method_query_builder.py` to validate `_MetodQueryBuilder` functionality. - Includes parameterized tests for valid method names and their expected outputs. - Tests for invalid method names and empty method names to ensure proper error handling. - Validates that the correct error messages are raised for invalid inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
feat: Enhance
_MetodQueryBuilderwith validation and tests, and improve type hinting inPySpringModelDescription:
This pull request introduces key enhancements and new features for the
PySpringModelframework.Changes in
_MetodQueryBuilder:get_by,find_by,find_all_by, orget_all_by. Invalid prefixes raise aValueErrorwith a detailed error message.test_method_query_builder.py.Changes in
PySpringModel:clonemethod to use theSelftype hint, enabling better type inference for inherited classes.get_primary_key_columnswhen the table is not found in metadata.Key Commits:
feat(PySpringModel)
Selftype hint forclone.get_primary_key_columns.PySpringModelfunctionality.refactor&test(_MetodQueryBuilder)
test_method_query_builder.py.chore
_find_all_by_query.