[MAINT] Deprecate distutils in favor of setuptools #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
matthewfeickert force-pushed the fix/remove-distutils branch from a7a7d3f to f6bf402 Compare 
matthewfeickert commented Jun 20, 2024
matthewfeickert force-pushed the fix/remove-distutils branch from f6bf402 to 3fd35e4 Compare matthewfeickert commented Jun 20, 2024
| Okay, this is ready for review now. |
| Hello, I agree that we should probably not add setuptools as install requirement. One solution would be indeed to add it for the tests and to allow to skip the test if not installed. WDYT? |
matthewfeickert force-pushed the fix/remove-distutils branch 2 times, most recently from 97a8f20 to 08b7f90 Compare
@rflamary I went with this, though I didn't add a skip as I just added |
| I would like to have the skip so that the tests do not fail if setuptools is not installed (for new developpers this could be frustrating). If you do not have tiome to do it let us just open an issue and merge the current PR |
* In CPython 3.10 distutils was formally marked as deprecated and was removed in Python 3.12 (https://peps.python.org/pep-0632/). Switch to using setuptools as a replacement, which offers a direct port of 'distutils.errors' as 'setuptools.errors'.
* To ensure that setuptools is available for setuptools.errors install it for all the tests in the CI. - setuptools.errors was added in v60.0.0 - c.f. https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html
matthewfeickert force-pushed the fix/remove-distutils branch from 08b7f90 to f1c683d Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Types of changes
Resolves #634
In CPython 3.10 distutils was formally marked as deprecated and was removed in Python 3.12 (https://peps.python.org/pep-0632/). Switch to using setuptools as a replacement, which offers a direct port of
distutils.errorsassetuptools.errors.To ensure that setuptools is available for
setuptools.errorsinstall it for all the tests in the CI.Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist