Make register auto tests support multi exercises with same name (#352)

Author: gal432

lms/lmstests/public/unittests/import_tests.py

@@ -13,28 +13,31 @@
 
 def register_test_class(file_path: str, test_class: typing.ClassVar):
  subject = test_class.__doc__
- exercise = models.Exercise.get_or_none(models.Exercise.subject == subject)
- if not exercise:
- log.info(f'Failed to find exercise subject {subject}')
+ exercises = tuple(
+ models.Exercise.filter(models.Exercise.subject == subject),
+ )
+ if not exercises:
+ log.info(f'Failed to find exercises for subject {subject}')
  raise SystemError
 
  with open(file_path, 'r') as file_reader:
  code = file_reader.read()
 
- exercise_test = models.ExerciseTest.get_or_create_exercise_test(
- exercise=exercise,
- code=code,
- )
+ for exercise in exercises:
+ exercise_test = models.ExerciseTest.get_or_create_exercise_test(
+ exercise=exercise,
+ code=code,
+ )
 
- for test_func_name in inspect.getmembers(test_class):
- test_func_name = test_func_name[0]
- if test_func_name.startswith('test_'):
- test_func = getattr(test_class, test_func_name)
- models.ExerciseTestName.create_exercise_test_name(
- exercise_test=exercise_test,
- test_name=test_func_name,
- pretty_test_name=test_func.__doc__,
- )
+  for test_func_name in inspect.getmembers(test_class):
+  test_func_name = test_func_name[0]
+  if test_func_name.startswith('test_'):
+  test_func = getattr(test_class, test_func_name)
+  models.ExerciseTestName.create_exercise_test_name(
+  exercise_test=exercise_test,
+  test_name=test_func_name,
+  pretty_test_name=test_func.__doc__,
+  )
 
 
 def load_tests_from_path(file_path: str):

tests/test_exercise_unit_tests.py

@@ -7,7 +7,6 @@
 from lms.models import notifications
 from tests import conftest
 
-
 STUDENT_CODE = """
 def foo(bar=None):
  return 'bar' if bar == 'bar' else 'foo'
@@ -70,6 +69,20 @@ def _verify_comments():
  assert expected == first.user_message
  assert "foo('bar') == 'barbaron'" in first.staff_message
 
+ def test_register_two_exercises_with_same_name(
+ self,
+ course: models.Course,
+ ):
+ ex1 = conftest.create_exercise(course, 0)
+ ex2 = conftest.create_exercise(course, 0)
+ import_tests.load_test_from_module(EXERCISE_TESTS)
+ assert models.ExerciseTest.select().filter(
+ models.ExerciseTest.exercise == ex1,
+ ).get()
+ assert models.ExerciseTest.select().filter(
+ models.ExerciseTest.exercise == ex2,
+ ).get()
+
  @staticmethod
  def _verify_notifications(solution):
  all_notifications = notifications.get(user=solution.solver)