Skip to content

Conversation

@gal432
Copy link
Member

@gal432 gal432 commented Nov 20, 2021

No description provided.

@gal432 gal432 requested a review from yammesicka November 20, 2021 19:11
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 20, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.72%.

Quality metrics Before After Change
Complexity 2.17 ⭐ 2.54 ⭐ 0.37 👎
Method Length 43.00 ⭐ 44.00 ⭐ 1.00 👎
Working memory 5.19 ⭐ 5.27 ⭐ 0.08 👎
Quality 85.03% 84.31% -0.72% 👎
Other metrics Before After Change
Lines 144 159 15
Changed files Quality Before Quality After Quality Change
lms/lmstests/public/unittests/import_tests.py 77.96% ⭐ 76.27% ⭐ -1.69% 👎
tests/test_exercise_unit_tests.py 89.94% ⭐ 89.43% ⭐ -0.51% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #352 (24f9091) into master (9499e89) will increase coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #352 +/- ## ======================================= Coverage 84.18% 84.19% ======================================= Files 63 63 Lines 2953 2954 +1 ======================================= + Hits 2486 2487 +1  Misses 467 467 
Impacted Files Coverage Δ
lms/lmstests/public/unittests/import_tests.py 72.09% <90.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9499e89...24f9091. Read the comment docs.

@gal432 gal432 merged commit 1bc1406 into master Nov 20, 2021
@gal432 gal432 deleted the feature/auto-tests-on-double-exercises branch November 20, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants