Skip to content

Conversation

tfeldmann
Copy link
Contributor

@tfeldmann tfeldmann commented Mar 21, 2022

Type of changes

  • Bug fix
  • Tests

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

Fixes Issue #528.

@tfeldmann
Copy link
Contributor Author

tfeldmann commented Mar 21, 2022

Oops, I forgot to fetch upstream before the implementation - the changelog has a merge conflict.

@lurch
Copy link
Contributor

lurch commented Mar 21, 2022

Apart from the still-present merge conflict, LGTM.

@lurch
Copy link
Contributor

lurch commented Mar 22, 2022

This PR adds 4 lots of def getsyspath but only 3 lots of def hassyspath ?

@tfeldmann
Copy link
Contributor Author

Fixed that, although hassyspath already returned False for ReadTarFS. I guess it's clearer this way.
Please do not merge yet, this PR needs some further discussion in #528.

@lurch lurch marked this pull request as draft March 22, 2022 11:44
@tfeldmann
Copy link
Contributor Author

Closing this as a non-issue, see #528

@tfeldmann tfeldmann closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants