Skip to content

Update ReadZipFS.openbin handler to use native Python zipfile code #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2022
Merged

Update ReadZipFS.openbin handler to use native Python zipfile code #527

merged 3 commits into from
Mar 13, 2022

Conversation

althonos
Copy link
Member

@althonos althonos commented Mar 13, 2022 •
edited
Loading

Type of changes

  • Bug fix

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @PyFilesystem/maintainers may be pedantic in the code review.

Description

This PR fixes two things with the ReadZipFS class:

  • Use the native mechanism implemented in zipfile for seeking files inside of Zip archives, instead of emulating it by re-opening and reading files.
  • Mark ReadZipFS as case-sensitive, since Zip archives are case-sensitive.
@althonos althonos mentioned this pull request Mar 13, 2022
Closed
@coveralls
Copy link

coveralls commented Mar 13, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 95.249% when pulling 7159a96 on fix-zipfs into f253d9f on master.
@althonos althonos added this to the v2.4.16 milestone Mar 13, 2022
@althonos althonos added the bug label Mar 13, 2022
@althonos althonos merged commit 8b72697 into master Mar 13, 2022
lurch
lurch reviewed Mar 13, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug

3 participants

@althonos @coveralls @lurch