Skip to content

Conversation

@juliepromact
Copy link
Collaborator

@juliepromact juliepromact commented Apr 10, 2017

Fixes #325

Files changed are:

1. .travis.yml - Updated version and path.
2. Dockerfile - Updated version and removed references to project,json.
3. Promact.Oauth.Server.sln - Visual Studio version updated.
4. global.json - Removed.
5. Promact.Oauth.Server.Tests.csproj - Added.
6. Promact.Oauth.Server.Tests.xproj - Removed.
7. project.json - Removed.
8. Promact.Oauth.Server.csproj - Added
9. Promact.Oauth.Server.xproj - Removed
10. Promact.Oauth.Server/project.json - Removed.
11. appveyor.yml - Updated version and path.

@codecov
Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #331 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## dev #331 +/- ## ======================================= Coverage 86.32% 86.32% ======================================= Files 17 17 Lines 702 702 Branches 149 149 ======================================= Hits 606 606 Misses 22 22 Partials 74 74

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74426e...9c54f38. Read the comment docs.

Dockerfile Outdated
@@ -1,9 +1,8 @@
FROM promact/docker-dotnet-nodejs:latest
FROM promact/docker-dotnet-nodejs:1.1.0-sdk-msbuild
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work. keep it as latest

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will update it.

}
},

"publishOptions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will publishOptions work now since project.json is removed

Copy link
Collaborator Author

@juliepromact juliepromact Apr 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .csproj

<ItemGroup> <None Update="wwwroot\**\*;Views\**\*;Areas\**\Views;nlog.config;Template\**\*"> <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> </None> </ItemGroup>

the above given code has been generated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it to
<ItemGroup> <None Update="wwwroot\**\*;Views\**\*;Areas\**\Views;nlog.config;Template\**\*;appsettings.json;StringLiterals\stringliterals.json;Seed\seeddata.json"> <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> </None> </ItemGroup>

@chintans chintans merged commit 4411da3 into dev Apr 12, 2017
@chintans chintans deleted the issue#325 branch April 12, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants