Code cleanup of the start script and ESHost.cs file #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Address some PSSA warnings, version guard access to $Is<platforms> vars, rename Test-NamedPipeName-OrCreate-IfNull to Get-ValidatedNamedPipeName. Not 100% sold on the new name so open to suggestions.
TylerLeonhardt approved these changes Nov 24, 2018
Member
TylerLeonhardt left a comment
TylerLeonhardt left a comment There was a problem hiding this comment.
LGTM! Just a couple comments. Thanks for the clean up, Keith!
rjmholt approved these changes Nov 24, 2018
Contributor
rjmholt left a comment
rjmholt left a comment There was a problem hiding this comment.
Much improved! Thanks @rkeithhill!
| Log $OutputEncoding | ||
| | ||
| function Test-NamedPipeName-OrCreate-IfNull { | ||
| function Get-ValidatedNamedPipeName { |
| await this.editorSession.PowerShellContext.ExecuteCommand<System.Management.Automation.PSObject>( | ||
| new System.Management.Automation.PSCommand().AddCommand("Import-Module").AddArgument(module), | ||
| new System.Management.Automation.PSCommand().AddCommand("Microsoft.PowerShell.Core\\Import-Module").AddArgument(module), | ||
| false, |
Contributor
There was a problem hiding this comment.
Maybe a good time to label these arguments too?
Contributor Author
There was a problem hiding this comment.
You mean .AddCommand("Microsoft.PowerShell.Core\\Import-Module").AddParameter("Name", module),? If so, yeah, makes senses to me.
Contributor
There was a problem hiding this comment.
Oh, I meant the true and false in C#. But I'm in favour of all of it :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Address some PSSA warnings, version guard access to
$Is<platform>vars,rename Test-NamedPipeName-OrCreate-IfNull to Get-ValidatedNamedPipeName.
Not 100% sold on the new name so open to suggestions.