Fix #181: Fix crash for unsupported field types #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change adds proper error handling for input prompt requests for field types that we don't yet support like SecureString and PSCredential. Previously any Read-Host or Get-Credential call which prompts for either of these types would crash the language and debugging services. The fix causes errors to be written to the host stating that these commands and field types are not yet supported.
daviwil added a commit that referenced this pull request Mar 8, 2016
Fix #181: Fix crash for unsupported field types
TylerLeonhardt pushed a commit to TylerLeonhardt/PowerShellEditorServices that referenced this pull request Feb 26, 2019
This change fixes an issue with the "Run Selection" command when it is executed on a line without any text being selected. In this case the expected behavior is to execute the entire line but only the line contents up to the cursor position were being executed. The fix is to change the content selection code to ensure that the line's full content is executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change adds proper error handling for input prompt requests for field
types that we don't yet support like SecureString and PSCredential.
Previously any Read-Host or Get-Credential call which prompts for either
of these types would crash the language and debugging services. The fix
causes errors to be written to the host stating that these commands and
field types are not yet supported.