Fix timing issues with OutputReader in host tests #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
daviwil force-pushed the daviwil/output-test-fix branch 2 times, most recently from e012fce to 2581eb0 Compare 
This change provides a fix with timing issues that can occur with tests which leverage the OutputReader class to read buffered output from the host process. It avoids test hangs by using a timeout of 5 seconds per read and handles an edge case where some line segments don't end with newlines.
daviwil force-pushed the daviwil/output-test-fix branch from 07fb743 to 1416412 Compare 
Contributor Author
| Not sure whether this will resolve the root cause but hopefully it will prevent future test hangs due to any issues. |
daviwil added a commit that referenced this pull request Feb 8, 2016
Fix timing issues with OutputReader in host tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change provides a fix with timing issues that can occur with tests
which leverage the OutputReader class to read buffered output from the
host process. It avoids test hangs by using a timeout of 5 seconds per
read and handles an edge case where some line segments don't end with
newlines.